An output policy for the three commands, and @cond as a true special form
A snapshot of the development tree. The substantial changes since the last one:
COMMAND OUTPUT POLICY. The three commands display text in exactly three cases,
and each owns a stream: LOGGING under "-v" greater than 0 and an ERROR before
termination go to STDERR; OUTPUT THE USER ASKED FOR goes to STDOUT. For ktext
that output is a document, so "ktext doc.kt -d | ..." is now safe -- logging
used to share the stream and land inside the document. A bare command prints
its usage and succeeds rather than failing. Colour is emitted only to a
terminal, per stream, and NO_COLOR is honoured.
"-v 1" reports every decision whose outcome you could not have read off your own
input: the klammerset that was loaded and from which file, a font's directory, a
":files" name's file, how "-o" was expanded. Higher levels are the trace.
The commands no longer warn and continue: an anomaly is an error, described with
its location. Two exceptions remain, each for a stated reason -- a condition
that is expected and temporary by design, and a judgment that is a heuristic
rather than exact.
@cond IS NOW A TRUE SPECIAL FORM, resolved at APPLICATION time rather than when
the file is read. Two consequences for a writer:
* a state variable reaches the predicate. "@@@state Flag :value true @@@
@cond *Flag* | T | F @" renders "T"; it used to see the literal "*Flag*" and
silently take the false branch. The document now behaves like a klammer
body, whose arguments are bound before its conditionals are decided.
* nothing in a discarded branch happens -- it is not read, not evaluated, not
expanded. An @eval in the branch not taken used to run anyway.
Its predicate relation is total and strict: true, True, 1; false, False, 0, and
empty; anything else is an error at the @cond rather than silently false.
@eval REACHING OUTSIDE. ":shell" and ":haskell" now keep the command's standard
error out of the document (it appears under "-v 1") and treat a nonzero exit as
an error naming what the command reported. A command that exits nonzero on
purpose -- "grep" finding no match -- says so with "|| true".
KLAMMER SETS. Several combine: "--klammersets a b c" loads all three in the
order given, sharing one namespace, with the definition modes deciding
collisions. "none" means none and may not be combined with other symbols. A
klammerset with symbol X is declared in a file X/X.k, which is what lets two
sets require the same third set without loading it twice.
TESTS. Four new suites: the kdiag command's interface, the @eval primitive's
contract with the outside world, and verbosity at both tiers. Three suites
that could not run on macOS at all now do.
Assembled from dev commit 6c8ee6c22fca.
This commit is contained in:
40
mac/argv.cpp
40
mac/argv.cpp
@@ -111,15 +111,18 @@ void Argv::flag(const std::string& name, const std::string& desc)
|
||||
update_width(arg);
|
||||
}
|
||||
|
||||
void Argv::req(const std::string& name, const std::string& desc, const std::string& regex_pattern)
|
||||
void Argv::req(const std::string& name, const std::string& desc,
|
||||
const std::string& regex_pattern, bool required)
|
||||
{
|
||||
(void)K::log(2, name, desc, regex_pattern);
|
||||
Arg arg {};
|
||||
arg.m_type = "req";
|
||||
// "posopt" is a positional that may be absent. It stays in m_req_names so
|
||||
// it keeps its POSITION; only its absence is tolerated.
|
||||
arg.m_type = required ? "req" : "posopt";
|
||||
arg.m_name = name;
|
||||
arg.m_desc = get_regex_desc(desc);
|
||||
arg.make_regex(regex_pattern);
|
||||
arg.m_syntax = "<" + name + ">";
|
||||
arg.m_syntax = required ? "<" + name + ">" : "[<" + name + ">]";
|
||||
m_args[name] = arg;
|
||||
m_names.push_back(name);
|
||||
m_req_names.push_back(name);
|
||||
@@ -191,17 +194,26 @@ void Argv::usage_line(Arg arg)
|
||||
<< wrap_around(arg.m_desc, m_syntax_size + 6) << "\n";
|
||||
}
|
||||
|
||||
// A positional argument, whether or not it may be absent. Both kinds are
|
||||
// listed under "Arguments:" and must therefore be skipped when the options are
|
||||
// listed -- testing only for "req" printed an optional positional twice, once
|
||||
// in each section (kdiag's "[<input>]").
|
||||
static bool is_positional(const std::string& type)
|
||||
{
|
||||
return type == "req" || type == "posopt";
|
||||
}
|
||||
|
||||
void Argv::usage(const std::string& command)
|
||||
{
|
||||
std::cout << "\nUsage: " << command << " ";
|
||||
for (const std::string& name : m_req_names) {
|
||||
std::cout << "<" + name + "> ";
|
||||
std::cout << m_args[name].m_syntax << " ";
|
||||
}
|
||||
if (m_opt_names.size() + m_flag_names.size() > 5) {
|
||||
std::cout << "[<optional-arguments>]\n";
|
||||
} else {
|
||||
for (const std::string& name : m_names) {
|
||||
if (m_args[name].m_type == "req") {
|
||||
if (is_positional(m_args[name].m_type)) {
|
||||
continue;
|
||||
}
|
||||
std::cout << "[" + m_args[name].m_syntax + "] ";
|
||||
@@ -222,7 +234,7 @@ void Argv::usage(const std::string& command)
|
||||
}
|
||||
|
||||
for (const auto& name : m_names) {
|
||||
if (m_args[name].m_type == "req") {
|
||||
if (is_positional(m_args[name].m_type)) {
|
||||
continue;
|
||||
}
|
||||
usage_line(m_args[name]);
|
||||
@@ -350,6 +362,12 @@ void Argv::parse_positional(const std::string& command, //strings_t words,
|
||||
auto arg = m_args[req];
|
||||
auto [substring, rest, found] = regex_split_prefix(arg.m_rgx, pos_args);
|
||||
if (!found) {
|
||||
// An optional positional simply stays empty; only a required one
|
||||
// is an error.
|
||||
if (arg.m_type == "posopt") {
|
||||
named_args[req] = "";
|
||||
continue;
|
||||
}
|
||||
std::stringstream ss {};
|
||||
ss << "The argument " << q_(req) << " was not found in:\n " << command;
|
||||
throw Argument_error(ss.str(), Locator(), false);
|
||||
@@ -409,7 +427,8 @@ void Argv::check_required(
|
||||
|
||||
if (required > given) {
|
||||
std::string missing = m_req_names[required - given - 1];
|
||||
if (given == 0 && m_args[missing].m_rgx_symbol == "'list'") {
|
||||
if (given == 0 && (m_args[missing].m_rgx_symbol == "'list'"
|
||||
|| m_args[missing].m_type == "posopt")) {
|
||||
return;
|
||||
}
|
||||
std::stringstream ss {};
|
||||
@@ -583,7 +602,8 @@ int Argv::as_verbosity(const std::string& name)
|
||||
std::string Argv::as_string(const std::string& name)
|
||||
{
|
||||
(void)K::log(2, name);
|
||||
return get(name);
|
||||
auto result = get(name);
|
||||
return result;
|
||||
}
|
||||
|
||||
strings_t Argv::as_vector(const std::string& name)
|
||||
@@ -622,7 +642,7 @@ std::pair<std::string, strings_t> Argv::as_input(const std::string& name, bool a
|
||||
return { input_text, input_filenames };
|
||||
}
|
||||
|
||||
void Argv::describe()
|
||||
void Argv::describe(std::ostream& os)
|
||||
{
|
||||
std::size_t width = std::accumulate(
|
||||
m_names.begin(), m_names.end(), 0,
|
||||
@@ -642,6 +662,6 @@ void Argv::describe()
|
||||
// whose whole job is to display what Argv parsed, was silent. The
|
||||
// callers already decide whether to call it (the commands gate it on
|
||||
// verbose_level > 0), so it prints unconditionally here.
|
||||
std::cout << ss.str() << "\n";
|
||||
os << ss.str() << "\n";
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user